Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgtool: Bump cryptography library version #1994

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

rustammendel
Copy link
Contributor

Update requirements.txt to support PrivateKeyType and PublicKeyType which are available in cryptography library since version 40.0.0 and prevent failing CI jobs in upcoming changes.

Update requirements.txt to support PrivateKeyType and
PublicKeyType which are available in cryptography library since
version 40.0.0 and prevent failing CI jobs in upcoming changes.

Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com>
Change-Id: I94b888d64c2f33ccb829912491e3b8c44b9cc2b2
@davidvincze
Copy link
Collaborator

davidvincze commented Jul 9, 2024

This change will affect all environments where the available cryptography Python package is older than 40.0.0.
The minimum version previously required (2.4.2) is from Nov 2018, and 40.0.0 is from March 2023. It's a sensible upgrade I think.

It is worth considering bumping the required version for an even more recent one (after evaluating the benefits of doing this, bug fixes?) - this should be a separate pull request.

@de-nordic de-nordic added crypto Encryption support area: imgtool labels Jul 24, 2024
@davidvincze davidvincze merged commit 49976dc into mcu-tools:main Jul 25, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: imgtool crypto Encryption support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants