Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgtool: Fix getpub fails for ed25519 key #2020

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

rustammendel
Copy link
Contributor

Fix getpub command fails to emit public pair of ed25519 key with encoding.

Addresses issue #1999

Fix getpub command fails to emit public pair of ed25519 key with
encoding.

Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com>
Change-Id: I3d255f576b2d8a8d0cbc8e31ff378717acb060c7
Copy link
Collaborator

@davidvincze davidvincze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srkapil
Copy link

srkapil commented Jul 27, 2024

Changes look good but please update the unit test scripts\imgtool\keys\ed25519_test.py to verify publice pem.

@davidvincze davidvincze merged commit ef598b1 into mcu-tools:main Jul 30, 2024
58 checks passed
@davidvincze
Copy link
Collaborator

Changes look good but please update the unit test scripts\imgtool\keys\ed25519_test.py to verify publice pem.

Please see #2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants