Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encrypted: Replace MCUBOOT_HW_KEY with the MCUBOOT_ENC_BUILTIN_KEY option #2037

Merged
merged 1 commit into from
Aug 21, 2024
Merged

encrypted: Replace MCUBOOT_HW_KEY with the MCUBOOT_ENC_BUILTIN_KEY option #2037

merged 1 commit into from
Aug 21, 2024

Conversation

davidvincze
Copy link
Collaborator

No description provided.

nordicjm
nordicjm approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK though the commits should be merged as first is lacking a description, change ID's not needed

@davidvincze
boot: Introduce the MCUBOOT_ENC_BUILTIN_KEY option
7260d0f 
- Introduce the MCUBOOT_ENC_BUILTIN_KEY config option for controlling the
usage of builtin key-encryption keys and replacing the MCUBOOT_HW_KEY
option in the image encryption module to avoid ambiguity as the latter
mentioned option is meant for configuring the handling of the
image verification keys,
- Add encryption build configs to template file.

Change-Id: Ic633d2103fb4e56d9fafdabef1fbddc3244cb795
Signed-off-by: David Vincze <david.vincze@arm.com>
@davidvincze
Copy link
Collaborator Author

Changes look OK though the commits should be merged as first is lacking a description, change ID's not needed

I've merged the 2 commits. The Change ID is needed for traceability in Gerrit based systems.

@davidvincze
Copy link
Collaborator Author

davidvincze commented Aug 19, 2024 •
edited
Loading

@DineshDK03, @mingulov any comments? Thank you!

@nordicjm nordicjm merged commit 6071ceb into mcu-tools:main Aug 21, 2024
58 checks passed
@davidvincze davidvincze deleted the enc-builtin-key branch August 26, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-nordic de-nordic de-nordic approved these changes

@nordicjm nordicjm nordicjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidvincze @nordicjm @de-nordic