bootutil: Fix image verification and add state to is header valid function #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nordicjm
commented
Aug 22, 2024
nordicjm
commented
Adds the state object to this function so it can be referenced Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
nordicjm
force-pushed
the
changesforcomp
branch
from
b3f39e1
to
2f31cd2
Compare
de-nordic
approved these changes
Aug 22, 2024
nordicjm
force-pushed
the
changesforcomp
branch
from
2f31cd2
to
07f1f53
Compare
nvlsianpu
approved these changes
Aug 26, 2024
utzig
reviewed
Aug 26, 2024
Changes the order of operations to validate the image header before checking the image, it does not make sense to check the image if the header itself is invalid Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds notes on the changed bootutil features Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
nordicjm
force-pushed
the
changesforcomp
branch
from
07f1f53
to
49a5872
Compare
utzig
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.