-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootutil: Add better mode selection checks #2047
Conversation
Currently, it fails because it needs a recently merged patch in TF-M: https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/30761 (modifying the default value of direct_xip_revert). I've just opened this PR to update the version of TF-M used in the fih-tests, however it also fails for a missing CMake dependency. @utzig could you help with updating the fih-test image on Docker Hub? |
Only I have access, but I'm pretty sure I sent @d3zd3z an invite, although he may not have accepted it since he's not showing up here. If you want one I can send to you. Or maybe it's also somewhat broken since they changed their plans for open-source projects. The best way forward is to migrate to Github's own hub which didn't exist back in the day. Anyway, I tried rebuilding the image, but it will still fail because cmake for focal is 3.16.3 (see: https://launchpad.net/ubuntu/focal/+package/cmake). So I'm gonna try building with jammy which has a newer cmake release that is new enough to not break the build (see: https://launchpad.net/ubuntu/jammy/+package/cmake). If the build succeeds I'll push 0.0.3 and open a PR with the updates. |
2bd15a4
to
e1fdffa
Compare
@davidvincze any clue as to how to update these tests? Seemingly TF-M has split tests off into another repo, the instructions state:
But this does not work:
|
This reverts commit ab4fb32. This was a wrong change and was caused by a faulty TFM board Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Improves the mode selection checks to prevent selecting multiple conflicting modes as has been seen in TFM Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Also reverts a change that was not needed