-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add issue and PR assigner #2064
Conversation
nordicjm
commented
Sep 16, 2024
3fee13e
to
ba5b84d
Compare
Adds a file with codeowners Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
.github/workflows/pr.yml
Outdated
- uses: actions/checkout@v1 | ||
- uses: ohnogumi/auto-reviewers@v0.0.5 | ||
with: | ||
token: "${{ secrets.USER_TOKEN }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried adding a USER_TOKEN
secret but this workflow still fails (here: https://github.com/actions/toolkit/blob/main/packages/github/src/internal/utils.ts#L11). The source of the error might be that the token is not being properly read, or it could even be that you are using string quotes here. I always write expressions without quotes around, eg, token: ${{ secrets.USER_TOKEN }}
. Not sure it would stop this from working though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the quotes but still failing, did you add this under mcuboot -> settings -> secrets and variables -> actions -> repository secrets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I've changed to a test action that I have tested and is known working in my own repo and I'm getting the same error that the parameter is empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, you could also try pushing your branch to this remote (instead of your fork), and point this PR to the locally pushed branch.
boot/cypress @romanjoe | ||
boot/espressif @almir-okato | ||
boot/mynewt @kasjer | ||
boot/nuttx @michallenc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both those users above are not collaborators in the project, and according to the error it needs to have "writer" access!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/managing-repository-roles/repository-roles-for-an-organization#permissions-for-each-role only read/triage permission should be needed. David has sent an invite to them in the comment above
Adds actions that will automatically assign users to reviews and issues Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>