Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add issue and PR assigner #2064

Closed
wants to merge 3 commits into from
Closed

Conversation

nordicjm
Copy link
Collaborator

Adds a file with codeowners



Adds actions that will automatically assign users to reviews
and issues

CODEOWNERS Outdated Show resolved Hide resolved
Adds a file with codeowners

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
- uses: actions/checkout@v1
- uses: ohnogumi/auto-reviewers@v0.0.5
with:
token: "${{ secrets.USER_TOKEN }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried adding a USER_TOKEN secret but this workflow still fails (here: https://github.com/actions/toolkit/blob/main/packages/github/src/internal/utils.ts#L11). The source of the error might be that the token is not being properly read, or it could even be that you are using string quotes here. I always write expressions without quotes around, eg, token: ${{ secrets.USER_TOKEN }}. Not sure it would stop this from working though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the quotes but still failing, did you add this under mcuboot -> settings -> secrets and variables -> actions -> repository secrets?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I've changed to a test action that I have tested and is known working in my own repo and I'm getting the same error that the parameter is empty

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, you could also try pushing your branch to this remote (instead of your fork), and point this PR to the locally pushed branch.

boot/cypress @romanjoe
boot/espressif @almir-okato
boot/mynewt @kasjer
boot/nuttx @michallenc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both those users above are not collaborators in the project, and according to the error it needs to have "writer" access!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds actions that will automatically assign users to reviews
and issues

Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
@nordicjm nordicjm closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants