imgtool's compression ARM thumb filter #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
requested changes
Oct 7, 2024
Adds ARM thumb filter to imgtool's LZMA2 compression. Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no>
michalek-no
force-pushed
the
mb-imgtool-armthumb
branch
from
4123b4d
to
9bef72e
Compare
michalek-no
force-pushed
the
mb-imgtool-armthumb
branch
from
9bef72e
to
8954949
Compare
nordicjm
reviewed
Oct 7, 2024
scripts/imgtool/image.py
Outdated
| @@ -535,6 +536,8 @@ def create(self, key, public_key_format, enckey, dependencies=None, | |||
| if compression_tlvs is not None: | |||
| if compression_type == "lzma2": | |||
| compression_flags = IMAGE_F['COMPRESSED_LZMA2'] | |||
| if compression_type == "lzma2armthumb": | |||
| compression_flags = IMAGE_F['COMPRESSED_ARM_THUMB'] | |||
There was a problem hiding this comment.
this needs to add both flags
michalek-no
force-pushed
the
mb-imgtool-armthumb
branch
from
8954949
to
9bef72e
Compare
nordicjm
pushed a commit
to nordicjm/sdk-mcuboot
that referenced
this pull request
Oct 7, 2024
Adds ARM thumb filter to imgtool's LZMA2 compression. Upstream PR: mcu-tools/mcuboot#2084 Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no>
nordicjm
approved these changes
Oct 7, 2024
nordicjm
pushed a commit
to nrfconnect/sdk-mcuboot
that referenced
this pull request
Oct 7, 2024
Adds ARM thumb filter to imgtool's LZMA2 compression. Upstream PR: mcu-tools/mcuboot#2084 Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no>
de-nordic
approved these changes
Oct 10, 2024
nvlsianpu
approved these changes
Oct 11, 2024
rlubos
pushed a commit
to rlubos/fw-nrfconnect-mcuboot
that referenced
this pull request
Oct 22, 2024
Adds ARM thumb filter to imgtool's LZMA2 compression. Upstream PR: mcu-tools/mcuboot#2084 Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit 94212b4)
rlubos
pushed a commit
to rlubos/fw-nrfconnect-mcuboot
that referenced
this pull request
Oct 22, 2024
Adds ARM thumb filter to imgtool's LZMA2 compression. Upstream PR: mcu-tools/mcuboot#2084 Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit 94212b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ARM thumb filter to imgtool's LZMA2 compression.