boot_serial: Fix serial recovery for LPC55x and MCXNx #2095
Conversation
butok
commented
Oct 14, 2024
•
butok
commented
- Increases the unaligned buffer default value for LPC55x and MCXNx.
- Fixes the serial recovery for LPC55x and MCXNx.
boot/zephyr/Kconfig.serial_recovery
Outdated
| default 64 | ||
| range 0 128 | ||
| default 512 | ||
| range 0 1024 |
There was a problem hiding this comment.
the default should be changed for your boards/socs, not every board. There is no reason every board with serial recovery should suddenly have an extra 448 bytes of RAM taken up for literally nothing
There was a problem hiding this comment.
Hi @nordicjm
The goal to have the same user experience as for Zephyr MCUMgr that works for all cases out of the box.
Having the higher value bring only benefits.
It works for all boards, faster, and without any resource penalty as the MCUBoot stack is too high - set to 10KB (used <20%).
There was a problem hiding this comment.
Sure, but you bring surprise to people who have tuned down stack and build of MCUboot, after this is brought in, topples into stack fault.
So now they have to go to their config files and bring that down.
I understand what you are trying to fix but you are not fixing that for everyone, quite an opposite.
The right approach is to have tuning done for device/soc/board.
Most people are not aware of the config or just briefly know of existence, because they have never had to deal with it as default worked.
There was a problem hiding this comment.
Sure, but you bring surprise to people who have tuned down stack and build of MCUboot, after this is brought in, topples into stack fault. So now they have to go to their config files and bring that down. I understand what you are trying to fix but you are not fixing that for everyone, quite an opposite. The right approach is to have tuning done for device/soc/board.
Most people are not aware of the config or just briefly know of existence, because they have never had to deal with it as default worked.
Updated.
Default value increased only for LPC55 and MCXN, for all other platforms unchanged.
- Increases the unaligned buffer default value for LPC55x and MCXNx. - Fixes the serial recovery for LPC55x and MCXNx. Signed-off-by: Andrej Butok <andrey.butok@nxp.com>
butok
force-pushed
the
serial_recovery_increase_buffer_range
branch
from
dd3121f
to
2ea791d
Compare
butok
changed the title
