Skip to content
This repository has been archived by the owner on Nov 24, 2019. It is now read-only.

Update README.md #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update README.md #22

wants to merge 4 commits into from

Conversation

CJeffyB
Copy link

@CJeffyB CJeffyB commented Mar 26, 2018

  • minor grammatical changes
  • Addresses Issue Unable to get display working at all. #13 by pointing to the TFT installation instructions on the wiki page
    (Currently the wiki page is on my fork, I cannot access the wiki page on the master. Please update.)

* minor grammatical changes
* moved installation instructions to wiki pages
Copy link
Owner

@mcuadros mcuadros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the small fixed, but can you avoid, make the lines longer than 80chars? (So not merge the paragraphs in one line, as it was)

README.md Outdated

### Dependencies
(If you are having difficulty getting this working with your TFT, please see the wiki page: [TFT Installation Tips](https://github.com/CJeffyB/OctoPrint-TFT/wiki/TFT-Installation-Tips))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move it to the bottom of the installation section?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@CJeffyB
Copy link
Author

CJeffyB commented Mar 29, 2018

I have moved the additional TFT installation instructions down, as requested. But I am unable to see what you mean by lines over 80chars causing problems... Is it something that is different on other browsers? I am using Chrome on Win 7 and Win 10, as well as IE on Win 7. It appears normal on all three...?

Copy link
Author

@CJeffyB CJeffyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK?

README.md Outdated

### Dependencies
(If you are having difficulty getting this working with your TFT, please see the wiki page: [TFT Installation Tips](https://github.com/CJeffyB/OctoPrint-TFT/wiki/TFT-Installation-Tips))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -96,23 +76,26 @@ and debian packages:
If you are using `Raspbian` you can install any of the `.deb` generated packages.
If not, just use the compiled binary.


### If you have difficulty getting this working with your TFT, please see the wiki page: [TFT Installation Tips](https://github.com/CJeffyB/OctoPrint-TFT/wiki/TFT-Installation-Tips)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace """ with just a >, also the wiki should be at this repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the """ you noted, so I'm not sure what needs to be replaced, exactly.

As for the wiki, I do not have rights to edit or add anything to your repository, and there is currently no wiki there. That is why it is on my git. I could not figure out how to do a pull request for the wiki, and am guessing it will have to be created by you, then copied and pasted...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants