debug: option to print using mnl format #219
Open
+600
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stapelberg
reviewed
Jan 5, 2025
mdlayher
reviewed
Jan 5, 2025
There was a problem hiding this comment.
This is awesome, I would be fine making this the default debugging format given that the existing one is probably not very useful for most circumstances.
I do think that the printer is complex enough to probably at least merit a unit test that dumps a fixed output and verifies that it does not drift.
Change-Id: I0d067261c1c30c0dc25fbc92f162b0a3746158ef
nftables uses the libmnl library that has a particular debugging format. This format is also used for nftables --debug=all. google/nftables golang library to interact with nftables uses this library to interface with netlink directly. Since these libraries are not well documented, is common to have to dump the netlink bits to compare. This commit implements an option to choose the same format used in nftables by adding a new option to the NLDEBUG environmenta variable and using the format=mnl key value. For Linux systems mnl is the default format. Change-Id: I5f63753b3ada4d25565fe0bddac35e010510a34f
@mdlayher added a commit to bump github actions and golang versions and defaulted the logger to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nftables uses the libmnl library that has a particular debugging format. This format is also used for nftables --debug=all. google/nftables golang library to interact with nftables uses this library to interface with netlink directly.
Since the netlink libraries and implementations are not well documented, is common to have to dump the netlink bits to compare.
This commit implements an option to choose the same format used in nftables by adding a new option to the NLDEBUG environmental variable and using the format=mnt key value.
Output of
nft --debug=allOutput of a
nftablesdump using google/nftables and setting the environment variablehttps://gist.github.com/aojea/8a811e11a060fa638aa2dd8165960d5a
NLDEBUG=format=mnl go run main.go cni-kindnet preroutingcc: @stapelberg