Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chrome/Safari data for -webkit-* CSS property #25424

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Update Chrome/Safari data for -webkit-* CSS property #25424

merged 4 commits into from
Jan 3, 2025

Conversation

queengooborg
Copy link
Contributor

This PR updates and corrects version values for Chrome and Safari for various -webkit-* CSS properties. The data comes from the mdn-bcd-collector project (v10.12.8).

Check out the collector's guide on how to review this PR.

@queengooborg
Update Chrome/Safari data for -webkit-* CSS property
33ed8f5 
This PR updates and corrects version values for Chrome and Safari for various `-webkit-*` CSS properties. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.12.8).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._
@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Dec 16, 2024
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Dec 16, 2024
caugner
caugner requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review pass for Chrome.

css/properties/-webkit-border-horizontal-spacing.json Outdated Show resolved Hide resolved
css/properties/-webkit-border-vertical-spacing.json Outdated Show resolved Hide resolved
css/properties/-webkit-column-break-after.json Outdated Show resolved Hide resolved
css/properties/-webkit-column-break-before.json Outdated Show resolved Hide resolved
css/properties/-webkit-column-break-inside.json Outdated Show resolved Hide resolved
css/properties/-webkit-text-decorations-in-effect.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-x.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-y.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-z.json Outdated Show resolved Hide resolved
css/properties/-webkit-user-drag.json Outdated Show resolved Hide resolved
caugner
caugner requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial pass for Safari changes.

css/properties/-webkit-border-horizontal-spacing.json Outdated Show resolved Hide resolved
css/properties/-webkit-border-vertical-spacing.json Outdated Show resolved Hide resolved
css/properties/-webkit-column-break-after.json Outdated Show resolved Hide resolved
css/properties/-webkit-column-break-before.json Outdated Show resolved Hide resolved
css/properties/-webkit-column-break-inside.json Outdated Show resolved Hide resolved
css/properties/-webkit-text-decorations-in-effect.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-x.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-y.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-z.json Outdated Show resolved Hide resolved
css/properties/-webkit-user-drag.json Outdated Show resolved Hide resolved
@queengooborg @caugner
Apply suggestions from code review
52a3205 
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
caugner
caugner requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass for Chrome, this time for alias properties (not reported by computed properties).

css/properties/-webkit-logical-height.json Outdated Show resolved Hide resolved
css/properties/-webkit-logical-width.json Outdated Show resolved Hide resolved
css/properties/-webkit-margin-after.json Outdated Show resolved Hide resolved
css/properties/-webkit-margin-before.json Outdated Show resolved Hide resolved
css/properties/-webkit-max-logical-height.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-x.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-y.json Outdated Show resolved Hide resolved
css/properties/-webkit-perspective-origin-x.json Outdated Show resolved Hide resolved
css/properties/-webkit-perspective-origin-y.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-z.json Outdated Show resolved Hide resolved
caugner
caugner requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second review pass for Safari, this time for alias properties (not reported by computed properties).

css/properties/-webkit-logical-height.json Outdated Show resolved Hide resolved
css/properties/-webkit-logical-width.json Outdated Show resolved Hide resolved
css/properties/-webkit-max-logical-height.json Outdated Show resolved Hide resolved
css/properties/-webkit-max-logical-width.json Outdated Show resolved Hide resolved
css/properties/-webkit-min-logical-height.json Outdated Show resolved Hide resolved
css/properties/-webkit-perspective-origin-x.json Outdated Show resolved Hide resolved
css/properties/-webkit-perspective-origin-y.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-x.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-y.json Outdated Show resolved Hide resolved
css/properties/-webkit-transform-origin-z.json Outdated Show resolved Hide resolved
@queengooborg @caugner
Apply suggestions from code review
4b7ff51 
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
@caugner caugner merged commit 82efbea into mdn:main Jan 3, 2025
9 checks passed
@queengooborg queengooborg deleted the css/properties/-webkit/webkit-corrections branch January 3, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @caugner