Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reject_pending_read_request and merge with releaseLock() #25516

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MattiasBuelens
Copy link

@MattiasBuelens MattiasBuelens commented Dec 27, 2024

Summary

Currently, we have a separate entry called reject_pending_read_request in both ReadableStreamDefaultReader and ReadableStreamBYOBReader (added in #16919) to show whether a browser has implemented the new behavior for releaseLock() specified in whatwg/streams#1168.

This PR merges that entry into the existing releaseLock() entry, marking the old behavior as a "partial implementation" instead. It also updates the compatibility data for the new behavior of releaseLock(). All major browsers now implement the new behavior.

Test results and supporting details

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Dec 27, 2024
@@ -262,14 +262,15 @@
},
"reject_pending_read_request": {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, should we just remove this entry and merge it into the releaseLock() entry? The new behavior is now well standardized and widely adopted.

Copy link
Contributor

@skyclouds2001 skyclouds2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api/ReadableStreamBYOBReader.json Outdated Show resolved Hide resolved
api/ReadableStreamDefaultReader.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Dec 28, 2024
@github-actions github-actions bot added size:l [PR only] 101-1000 LoC changed and removed size:m [PR only] 25-100 LoC changed labels Dec 28, 2024
@MattiasBuelens MattiasBuelens changed the title Update reject_pending_read_request Update reject_pending_read_request and merge with releaseLock() Dec 28, 2024
@MattiasBuelens
Copy link
Author

MattiasBuelens commented Dec 28, 2024

I went ahead and removed the reject_pending_read_request entry, merging it into the existing releaseLock() entry. I think this better reflects that this behavior change only affects the releaseLock() method, and that older versions with the old behavior are only "partially" implementing the standard.

I believe this removal is warranted under the rules for removing irrelevant features, but I'm open to discuss. Maybe @hamishwillee could chime in, as they added the feature in the first place in #16919? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants