-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reject_pending_read_request
and merge with releaseLock()
#25516
base: main
Are you sure you want to change the base?
Update reject_pending_read_request
and merge with releaseLock()
#25516
Conversation
api/ReadableStreamDefaultReader.json
Outdated
@@ -262,14 +262,15 @@ | |||
}, | |||
"reject_pending_read_request": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, should we just remove this entry and merge it into the releaseLock()
entry? The new behavior is now well standardized and widely adopted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and need to add an entry to https://github.com/mdn/browser-compat-data/blob/main/browsers/nodejs.json
reject_pending_read_request
and merge with releaseLock()
I went ahead and removed the I believe this removal is warranted under the rules for removing irrelevant features, but I'm open to discuss. Maybe @hamishwillee could chime in, as they added the feature in the first place in #16919? 🙂 |
Summary
Currently, we have a separate entry called
reject_pending_read_request
in bothReadableStreamDefaultReader
andReadableStreamBYOBReader
(added in #16919) to show whether a browser has implemented the new behavior forreleaseLock()
specified in whatwg/streams#1168.This PR merges that entry into the existing
releaseLock()
entry, marking the old behavior as a "partial implementation" instead. It also updates the compatibility data for the new behavior ofreleaseLock()
. All major browsers now implement the new behavior.Test results and supporting details
ReadableStreamBYOBReader
, so I only updated the data forReadableStreamDefaultReader
.