Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSSSyntax for at-rules and at-rule descriptors #22167

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Nov 8, 2022

When we replaced mdn/data with webref for the formal syntax, we had to remove {{csssyntax}} calls for at-rules and at-rule descriptors, because webref didn't make it easy to get values for them.

Now it does! So I filed mdn/yari#7322 to make {{csssyntax}} understand how to get values for these things. That PR got merged yesterday, so here's the content part.

There are two exceptional cases:

For the time being I'm just hardcoding these values and not using {{csssyntax}}, but it might be possible to fix one or both of them upstream.

@wbamberg wbamberg requested a review from a team as a code owner November 8, 2022 18:33
@wbamberg wbamberg requested review from dipikabh and removed request for a team November 8, 2022 18:33
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Preview URLs (37 pages)
Flaws (9)

Note! 29 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/@media
Title: @media
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/CSS/@font-face
Title: @font-face
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/CSS/@namespace
Title: @namespace
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Namespaces

URL: /en-US/docs/Web/CSS/@page
Title: @page
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/CSS/@counter-style/additive-symbols
Title: additive-symbols
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/system redirects to /en-US/docs/Web/CSS/@counter-style/system

URL: /en-US/docs/Web/CSS/@layer
Title: @layer
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Learn/CSS/Building_blocks/Cascade_and_inheritance
    • Can't resolve /en-US/docs/Web/Learn/CSS/Building_blocks/Cascade_layers

URL: /en-US/docs/Web/CSS/@color-profile
Title: @color-profile
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: css.at-rules.color-profile

URL: /en-US/docs/Web/CSS/@import
Title: @import
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/user_agents does not exist

(this comment was updated 2022-11-08 22:35:47.541741)

@dipikabh dipikabh self-assigned this Nov 8, 2022
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dipikabh dipikabh merged commit 04fdfd7 into mdn:main Nov 9, 2022
@wbamberg wbamberg deleted the at-rule-csssyntax branch April 5, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants