Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clonable option and attribute #31849

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Add clonable option and attribute #31849

merged 5 commits into from
Jan 24, 2024

Conversation

pepelsbey
Copy link
Member

Description

  • Adds clonable option to the attachShadow
  • Adds clonable property to the ShadowRoot

Motivation

To support the upcoming Firefox implementation.

Additional details

Related issues and pull requests

@pepelsbey pepelsbey requested a review from a team as a code owner January 22, 2024 16:00
@pepelsbey pepelsbey requested review from sideshowbarker and removed request for a team January 22, 2024 16:00
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Jan 22, 2024
@pepelsbey pepelsbey requested review from dipikabh and bsmth and removed request for sideshowbarker January 22, 2024 16:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024 •
edited
Loading

Preview URLs

Flaws (4)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/ShadowRoot
Title: ShadowRoot
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/ShadowRoot/getSelection does not exist
    • /en-US/docs/Web/API/ShadowRoot/elementFromPoint does not exist
    • /en-US/docs/Web/API/ShadowRoot/elementsFromPoint does not exist

URL: /en-US/docs/Web/API/ShadowRoot/clonable
Title: ShadowRoot: clonable property
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.ShadowRoot.clonable

(comment last updated: 2024-01-24 13:57:32)

@pepelsbey pepelsbey mentioned this pull request Jan 22, 2024
Closed
10 tasks
bsmth
bsmth approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This BCD PR should fix broken spec URLs etc.: mdn/browser-compat-data#21948

dipikabh
dipikabh approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @pepelsbey!
Just a few nits that can be fixed, leaving my +1.

files/en-us/web/api/shadowroot/clonable/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/shadowroot/index.md Outdated Show resolved Hide resolved
@pepelsbey @dipikabh
Apply suggestions from code review
d576a41 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@pepelsbey pepelsbey merged commit 7ecc4ef into main Jan 24, 2024
9 checks passed
@pepelsbey pepelsbey deleted the shadowroot-clonable branch January 24, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepelsbey @dipikabh @bsmth