chore(scss): remove unused notecards styles #10957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should've been removed with this change dbaddf2#diff-02e340b05a9a9ea19debcc122fbcc6f15b12ef200cf0f4d99821ebb131d2c90a
caugner
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Noticed when reviewing #10943
Problem
Old, unused, unimported, notecard styles left over from before redesign, should've been removed with this change dbaddf2#diff-02e340b05a9a9ea19debcc122fbcc6f15b12ef200cf0f4d99821ebb131d2c90a
Solution
Remove the file
Screenshots
No change
How did you test this change?
Grepped to make sure the file wasn't imported anywhere, also quickly checked http://localhost:3000/en-US/docs/Learn#where_to_start to ensure the notecard still rendered properly