-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rari): use rari as default #12322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: rari is used by default use :legacy commands for yari
github-actions
bot
added
dependencies
Pull requests that update a dependency file
github-actions
labels
Dec 17, 2024
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
argl
approved these changes
Dec 17, 2024
pepelsbey
pushed a commit
to pepelsbey/mdn-yari
that referenced
this pull request
Dec 21, 2024
* feat(rari): use rari as default BREAKING CHANGE: rari is used by default use :legacy commands for yari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Warning
If this breaks anything please report bugs in yari of talk to us on discord in the platform channel.
Switch to rari for production build and for most commands:
Added :legacy versions to use the old system.
This means we now use the new sidebars in files/sidebars and L10n-Template for macro translations.
We also start to remove a lot of the outdated tests (a lot still us html for content 😞 ).
BREAKING CHANGE: rari is used by default use :legacy commands for yari
How did you test this change?
This has been used for staging for > 1 month now.