Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move alembic config into mealie package for easier distribution #4329

Open
wants to merge 1 commit into
base: mealie-next
Choose a base branch
from

Conversation

chishm
Copy link
Contributor

@chishm chishm commented Oct 7, 2024

What type of PR is this?

  • cleanup
  • feature

What this PR does / why we need it:

The Alembic configuration and database migration scripts are moved inside the mealie Python package. This means they will be always available, in a consistent location. The advantages are:

  • No extra step needed during mealie installation to add the Alembic configuration and scripts.
  • No need to guess where the configuration is, so the ALEMBIC_CONFIG_FILE environment variable doesn't need to be set, ever. I've left it in as an option for people who still want to use it.

As a side effect, ruff (specifically isort) no longer thinks alembic is a project ("LOCALFOLDER") package, so the imports of alembic are moved to the third-party group.

Which issue(s) this PR fixes:

This is one task from discussion #4322.

Testing

I built and ran the Docker container, then made sure the database migration still occurred.

I created a database change following the instructions in database-changes.md.

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the stale label Nov 22, 2024
@chishm
Copy link
Contributor Author

chishm commented Nov 22, 2024

I'm waiting on #4551 to be reviewed and merged before I rebase this PR for merge.

But if someone wants to review this one first, I'm happy to rebase now.

@github-actions github-actions bot removed the stale label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant