Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3892 missing parameter documentation #4577

Open
wants to merge 1 commit into
base: mealie-next
Choose a base branch
from

Conversation

VTerret
Copy link

@VTerret VTerret commented Nov 18, 2024

What type of PR is this?

  • documentation

What this PR does / why we need it:

This push request adds a missing parameter on the postgres example which causes an error log in the docker console.

Which issue(s) this PR fixes:

Fixes #3892

@boc-the-git
Copy link
Collaborator

Please provide a meaningful title to the pull request.

@VTerret VTerret changed the title Fix: 3892 fix: 3892 Nov 19, 2024
add parameter on documentation
@VTerret VTerret changed the title fix: 3892 fix: 3892 missing parameter documentation Nov 19, 2024
@michael-genson
Copy link
Collaborator

Is there a reason not to update the healthcheck instead? So configuration is easier if users want to customize it for some reason. e.g.
test: ["CMD", "pg_isready", "-U", "$$POSTGRES_USER", "-d", "$$POSTGRES_DB"]

(Also if you could verify this works, I'm just basing this off the linked stackoverflow thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - SQLite to PostgreSQL FATAL: role "root" does not exist
3 participants