Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore custom systemd service with APT #5

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

yzoug
Copy link

@yzoug yzoug commented Oct 18, 2023

Instead of disabling and stopping the default APT systemd service, we rely on it to handle supervisor instead of the custom systemd service file supplied by the role, when using APT instead of pip for the install.

Yassine Zouggari added 2 commits October 18, 2023 14:06
This variable contains the name of the systemd service installed.
Defaults to `supervisord`, the name of the systemd service installed by
this role by default (i.e. when using pip).
Instead of disabling and stopping the default APT systemd service, we
rely on it to handle supervisor instead of the custom systemd service
file supplied by the role, when using APT instead of pip for the
install.
@yzoug yzoug requested review from desbouis, Jamal-B and loliee October 18, 2023 12:19
@yzoug yzoug self-assigned this Oct 18, 2023
@loliee
Copy link
Member

loliee commented Oct 18, 2023

Pourquoi on garde ça :

- name: Copy Supervisor unit file into place (for systemd systems).
?

[EDIT] oublis ma remarque…

@yzoug yzoug merged commit 4de5b14 into master Oct 23, 2023
5 checks passed
@yzoug yzoug deleted the feat/ignore-custom-systemd-service-with-apt branch October 23, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants