Feat/tray menu/shortcut recording #552

onyedikachi-david · 2024-10-21T16:43:58Z

Fixes: #515
/claim #515

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

Signed-off-by: David Anyatonwu <51977119+onyedikachi-david@users.noreply.github.com>

vercel · 2024-10-21T16:44:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
screenpipe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 13, 2024 2:32pm

louis030195 · 2024-10-21T17:55:10Z

@onyedikachi-david great work!

can you make sure to follow style guide (e.g. UI strings in lower case like in the cursor rules https://github.com/mediar-ai/screenpipe/blob/main/.cursorrules)
the shortcut UI settings is still a bit weird to me, like i dont get why my shortcut still require cmd when i did not select it?

that would great if you could find how to fix this?

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

onyedikachi-david · 2024-10-22T14:11:45Z

Screen.Recording.2024-10-22.at.14.55.44.mov

How do you see this method? @louis030195

louis030195 · 2024-10-22T15:22:19Z

Screen.Recording.2024-10-22.at.14.55.44.mov
How do you see this method? @louis030195

nice, dream would be same UX as obsidian:

Screen.Recording.2024-10-22.at.08.20.34.mov

can you make it like this? then make same UX for the other shortcut setting, solve conflict and can merge 🙏

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

onyedikachi-david · 2024-10-23T13:14:07Z

onyedikachi-david · 2024-10-23T13:14:28Z

is this okay @louis030195

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

louis030195 · 2024-10-24T15:51:26Z

@onyedikachi-david good!

why is written super? it should be the cmd icon on mac and ctrl on windows i guess

also the shortcut does not work for me

i checked out the PR, did bun tauri dev

pressing the shortcut nothing happen

saving does not work (e.g. changing shortcut, leaving settings page and coming back does not save)

can you fix these and we can merge then

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

onyedikachi-david · 2024-10-25T16:09:54Z

why is written super? it should be the cmd icon on mac and ctrl on windows i guess

Everything should be working well now. @louis030195

louis030195 · 2024-10-25T16:10:43Z

@onyedikachi-david just changed slightly command.rs for security (app was crashing) can you rebase/resolve conflicts?

onyedikachi-david · 2024-10-25T16:12:53Z

@onyedikachi-david just changed slightly command.rs for security (app was crashing) can you rebase/resolve conflicts?

Just did :)

louis030195 · 2024-10-25T16:17:50Z

@onyedikachi-david saving still does not work, nor the shortcut itself, nothing happen, no notification and not starting the recording

onyedikachi-david · 2024-10-25T16:23:08Z

Wow, that's odd, but can you see these logs?

2024-10-25T16:20:50.929120Z DEBUG screenpipe_app::commands: Registering shortcuts - Show: Meta+Ctrl+Y, Record: Meta+Alt+T
2024-10-25T16:20:50.931642Z DEBUG screenpipe_app::commands: Successfully unregistered existing shortcuts
2024-10-25T16:20:50.931653Z DEBUG screenpipe_app::commands: Parsing show screenpipe shortcut
2024-10-25T16:20:50.931709Z DEBUG screenpipe_app::commands: Starting to parse shortcut: Meta+Ctrl+Y
2024-10-25T16:20:50.934688Z DEBUG screenpipe_app::commands: Split shortcut into parts: ["Meta", "Ctrl", "Y"]
2024-10-25T16:20:50.934735Z DEBUG screenpipe_app::commands: Modifiers: ["Meta", "Ctrl"], Key: ["Y"]
2024-10-25T16:20:50.936304Z DEBUG screenpipe_app::commands: Processing modifier: Meta
2024-10-25T16:20:50.938026Z DEBUG screenpipe_app::commands: Adding META modifier
2024-10-25T16:20:50.938115Z DEBUG screenpipe_app::commands: Processing modifier: Ctrl
2024-10-25T16:20:50.938128Z DEBUG screenpipe_app::commands: Adding CONTROL modifier
2024-10-25T16:20:50.938135Z DEBUG screenpipe_app::commands: Final modifier flags: Modifiers(CONTROL | META)
2024-10-25T16:20:50.945071Z DEBUG screenpipe_app::commands: Attempting to parse key code: KeyY
2024-10-25T16:20:50.945101Z DEBUG screenpipe_app::commands: Successfully parsed key code: KeyY
2024-10-25T16:20:50.946724Z DEBUG screenpipe_app::commands: Parsing recording shortcut
2024-10-25T16:20:50.946732Z DEBUG screenpipe_app::commands: Starting to parse shortcut: Meta+Alt+T
2024-10-25T16:20:50.946777Z DEBUG screenpipe_app::commands: Split shortcut into parts: ["Meta", "Alt", "T"]
2024-10-25T16:20:50.946790Z DEBUG screenpipe_app::commands: Modifiers: ["Meta", "Alt"], Key: ["T"]
2024-10-25T16:20:50.946797Z DEBUG screenpipe_app::commands: Processing modifier: Meta
2024-10-25T16:20:50.946804Z DEBUG screenpipe_app::commands: Adding META modifier
2024-10-25T16:20:50.946817Z DEBUG screenpipe_app::commands: Processing modifier: Alt
2024-10-25T16:20:50.946825Z DEBUG screenpipe_app::commands: Adding ALT modifier
2024-10-25T16:20:50.946831Z DEBUG screenpipe_app::commands: Final modifier flags: Modifiers(ALT | META)
2024-10-25T16:20:50.946840Z DEBUG screenpipe_app::commands: Attempting to parse key code: KeyT
2024-10-25T16:20:50.946846Z DEBUG screenpipe_app::commands: Successfully parsed key code: KeyT
2024-10-25T16:20:50.946880Z DEBUG screenpipe_app::commands: Registering show screenpipe shortcut
2024-10-25T16:20:50.952000Z DEBUG screenpipe_app::commands: Registering recording shortcut
2024-10-25T16:20:50.952119Z DEBUG screenpipe_app::commands: Successfully registered all shortcuts

louis030195 · 2024-10-25T18:47:30Z

yes i do but the ui settings does not update, some issue with the typescript code, also meta key crash my app:

 invalid shortcut 'Meta+Shift+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:15.474680Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+super+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:18.701527Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+shift+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:20.764464Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+shift+alt+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:23.644786Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+ctrl+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:25.740428Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default
2024-10-25T18:45:45.954858Z  INFO screenpipe_app::commands: invalid shortcut 'Meta+Shift+P': Couldn't recognize "Meta" as a valid key for hotkey, if you feel like it should be, please report this to https://github.com/tauri-apps/muda, falling back to default

isn't it "Super" ? or idk

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

onyedikachi-david · 2024-10-31T18:34:25Z

@onyedikachi-david i meant the shortcut to show the app (not the one to record which works for me)

Okay.

I'll see to it. But it should just work, I just moved the function call. 🙂.

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

onyedikachi-david · 2024-11-01T08:42:50Z

Screen.Recording.2024-11-01.at.09.32.08.mov

It is fixed now sir. apologies for the stress.

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

louis030195 · 2024-11-01T17:45:18Z

@onyedikachi-david
unfortunately it's still a bit weird:

when i sat cmd+shift+u as shortcut i need to press twice to show up instead of once
when i sat cmd+w as shortcut it wouldn't work at all

IMG.5897.mov

onyedikachi-david · 2024-11-01T18:05:24Z

Yes, for the twice stuff, i noticed it myself, i'm using a boolean flag to check if the sidecar is running so i can either start or stop, it is supposed to return Some if running or None if not, but it doesn't, so I have to find a way around it (please see the comment in the code snippet).

 } else if normalized_shortcut == normalized_toggle_shortcut {
                    tokio::task::block_in_place(move || {
                        Handle::current().block_on(async move {
                            let state = app.state::<SidecarState>();
                            let mut sidecar = state.0.lock().await;
                            debug!("sidecar state: {:?}", sidecar.is_some());
                            
                            // Drop the lock before performing actions
                            let is_running = sidecar.is_some(); // This was always returning false even when it is running.
                            *sidecar = None; // Adding this made it work as it does now.
                            drop(sidecar);  
                            
                            if is_running {  
                                debug!("Stopping screenpipe via shortcut");
                                if let Err(err) = kill_all_sreenpipes(state.clone(), app.clone()).await {
                                    error!("Failed to stop recording: {}", err);
                                    let _ = app.notification().builder()
                                        .title("Screenpipe")
                                        .body("Failed to stop recording")
                                        .show();
                                    let _ = app.emit("recording_failed", "Failed to stop recording");
                                } else {
                                    let _ = app.notification().builder()
                                        .title("Screenpipe")
                                        .body("Recording stopped")
                                        .show();
                                    let _ = app.emit("recording_stopped", "Recording stopped");
                                }
                            }

louis030195 · 2024-11-02T00:16:14Z

screenpipe-app-tauri/src-tauri/src/main.rs

+
+                    show_main_window(&app_handle, true);
+                } else if normalized_shortcut == normalized_toggle_shortcut {
+                    tokio::task::block_in_place(move || {


you should probably use tauri::async stuff

tauri::async_runtime::spawn(async move {

louis030195 · 2024-11-02T00:18:14Z

screenpipe-app-tauri/src-tauri/src/main.rs

@@ -204,6 +325,48 @@ async fn main() {
                        println!("quit clicked");
                        app_handle.exit(0);
                    }
+                    "start_recording" => {
+                        tokio::task::block_in_place(move || {
+                            Handle::current().block_on(async move {


tauri::async_runtime::spawn(async move { might be better (not sure why we used tokio before)

louis030195 · 2024-11-02T00:21:15Z

screenpipe-app-tauri/src-tauri/src/commands.rs

 use tracing::info;
+use tracing::{debug, error};


make sure there are no duplicate keys or shortcuts added, that might cause issues (use set, or things like this)

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

louis030195 · 2024-11-05T23:01:07Z

@onyedikachi-david it would be great to make this work and merge today, i need this for the timeline UI shortcut

onyedikachi-david · 2024-11-06T05:13:57Z

@onyedikachi-david it would be great to make this work and merge today, i need this for the timeline UI shortcut

okay. apologies for the delay.

louis030195 · 2024-11-11T23:35:12Z

any news on this?

onyedikachi-david · 2024-11-12T16:55:34Z

I have a fix, will push soon, apologies for the delay.

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

onyedikachi-david · 2024-11-13T14:06:13Z

Screen.Recording.2024-11-13.at.14.35.02.mov

onyedikachi-david · 2024-11-16T16:35:34Z

@louis030195 Hi, i don't know if you've gotten time to review this?

louis030195 · 2024-11-18T17:26:46Z

same issue, i need to press twice the shortcut to work

onyedikachi-david · 2024-11-20T15:41:44Z

I'm just at lost on how and why this is happening. It happens only for the overlay shortcut. I'll try to figure it out.

onyedikachi-david and others added 3 commits October 21, 2024 13:52

feat: shortcut

e447b6b

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

feat: shortcut menu

292fd14

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

feat(shortcuts): implement recording shortcut functionality

d59f338

Signed-off-by: David Anyatonwu <51977119+onyedikachi-david@users.noreply.github.com>

vercel bot deployed to Preview October 21, 2024 16:45 View deployment

chore: refactor recording shortcut settings

ad8b354

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

vercel bot deployed to Preview October 22, 2024 14:06 View deployment

chore: shortcut ui revamp

4e11569

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

vercel bot deployed to Preview October 23, 2024 12:57 View deployment

fix: parse keyboard shortcut in commands.rs

345d348

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

vercel bot deployed to Preview October 23, 2024 13:46 View deployment

Merge branch 'main' into feat/tray-menu-recording

4069220

vercel bot deployed to Preview October 23, 2024 13:50 View deployment

fix

07786b2

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

vercel bot deployed to Preview October 25, 2024 16:09 View deployment

Merge branch 'main' into feat/tray-menu-recording

23158d4

vercel bot deployed to Preview October 25, 2024 16:13 View deployment

fix

5bab5ed

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

fix window overlay issues

578d6e2

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

vercel bot deployed to Preview November 1, 2024 08:43 View deployment

Merge branch 'main' into feat/tray-menu-recording

e329bf0

vercel bot deployed to Preview November 1, 2024 10:26 View deployment

fixed merge issues

695bf21

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

vercel bot deployed to Preview November 1, 2024 10:58 View deployment

added deno binary to gitignore

5e53464

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

vercel bot deployed to Preview November 1, 2024 11:04 View deployment

louis030195 reviewed Nov 2, 2024

View reviewed changes

use async

d3e25d6

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

vercel bot deployed to Preview November 4, 2024 03:22 View deployment

fix shortcut issues

2b4d2be

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>

vercel bot deployed to Preview November 13, 2024 13:42 View deployment

Merge branch 'main' into feat/tray-menu-recording

e0bd376

vercel bot deployed to Preview November 13, 2024 14:32 View deployment

louis030195 mentioned this pull request Nov 20, 2024

[bounty] make #552 work #713

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/tray menu/shortcut recording #552

Feat/tray menu/shortcut recording #552

onyedikachi-david commented Oct 21, 2024

vercel bot commented Oct 21, 2024 •

edited

Loading

louis030195 commented Oct 21, 2024

onyedikachi-david commented Oct 22, 2024

louis030195 commented Oct 22, 2024

onyedikachi-david commented Oct 23, 2024

onyedikachi-david commented Oct 23, 2024

louis030195 commented Oct 24, 2024

onyedikachi-david commented Oct 25, 2024

louis030195 commented Oct 25, 2024

onyedikachi-david commented Oct 25, 2024

louis030195 commented Oct 25, 2024

onyedikachi-david commented Oct 25, 2024

louis030195 commented Oct 25, 2024

onyedikachi-david commented Oct 31, 2024

onyedikachi-david commented Nov 1, 2024

louis030195 commented Nov 1, 2024

onyedikachi-david commented Nov 1, 2024

louis030195 Nov 2, 2024

louis030195 Nov 2, 2024

louis030195 Nov 2, 2024

louis030195 Nov 2, 2024

louis030195 commented Nov 5, 2024

onyedikachi-david commented Nov 6, 2024

louis030195 commented Nov 11, 2024

onyedikachi-david commented Nov 12, 2024

onyedikachi-david commented Nov 13, 2024

onyedikachi-david commented Nov 16, 2024

louis030195 commented Nov 18, 2024

onyedikachi-david commented Nov 20, 2024

Feat/tray menu/shortcut recording #552

Are you sure you want to change the base?

Feat/tray menu/shortcut recording #552

Conversation

onyedikachi-david commented Oct 21, 2024

vercel bot commented Oct 21, 2024 • edited Loading

louis030195 commented Oct 21, 2024

onyedikachi-david commented Oct 22, 2024

louis030195 commented Oct 22, 2024

onyedikachi-david commented Oct 23, 2024

onyedikachi-david commented Oct 23, 2024

louis030195 commented Oct 24, 2024

onyedikachi-david commented Oct 25, 2024

louis030195 commented Oct 25, 2024

onyedikachi-david commented Oct 25, 2024

louis030195 commented Oct 25, 2024

onyedikachi-david commented Oct 25, 2024

louis030195 commented Oct 25, 2024

onyedikachi-david commented Oct 31, 2024

onyedikachi-david commented Nov 1, 2024

louis030195 commented Nov 1, 2024

onyedikachi-david commented Nov 1, 2024

louis030195 Nov 2, 2024

Choose a reason for hiding this comment

louis030195 Nov 2, 2024

Choose a reason for hiding this comment

louis030195 Nov 2, 2024

Choose a reason for hiding this comment

louis030195 Nov 2, 2024

Choose a reason for hiding this comment

louis030195 commented Nov 5, 2024

onyedikachi-david commented Nov 6, 2024

louis030195 commented Nov 11, 2024

onyedikachi-david commented Nov 12, 2024

onyedikachi-david commented Nov 13, 2024

onyedikachi-david commented Nov 16, 2024

louis030195 commented Nov 18, 2024

onyedikachi-david commented Nov 20, 2024

vercel bot commented Oct 21, 2024 •

edited

Loading