Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: brew update #733

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

krushnarout
Copy link
Contributor


name: pull request
about: submit changes to the project
title: fix: brew update
labels: ''
assignees: ''


description

brief description of the changes in this pr.

related issue: #

type of change

  • bug fix
  • new feature
  • breaking change
  • documentation update

how to test

add a few steps to test the pr in the most time efficient way.

if relevant add screenshots or screen captures to prove that this PR works to save us time.

checklist

  • MOST IMPORTANT: this PR will require less than 30 min to review, merge, and release to production and not crash in the hand of thousands of users
  • i have read the CONTRIBUTING.md file
  • i have updated the documentation if necessary
  • my changes generate no new warnings
  • i have added tests that prove my fix is effective or that my feature works

additional notes

any other relevant information about the pr.

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ❌ Failed (Inspect) Nov 22, 2024 1:23am

@louis030195
Copy link
Collaborator

@krushnarout how do you know it works?

@krushnarout
Copy link
Contributor Author

@krushnarout how do you know it works?

I used --dry-run it’s the only way I can check from my side. It prints the sha256 correctly.

@krushnarout
Copy link
Contributor Author

@louis030195 Please use a different version because it takes this as a duplicate PR. Otherwise, use --force. Ref: Search for closed duplicate PRs as part of bump-formula-pr. In this, a warning of a possibly duplicate PR will be printed, but it would allow a person to override it with the --force flag."

@krushnarout
Copy link
Contributor Author

@louis030195 I have an idea. Instead of making the PR right away, we can simply do

Comment out the brew bump-formula-pr code and first check if it logs the URL and SHA256 correctly. If everything looks correct, then uncomment the brew bump-formula-pr code to proceed with the PR.

 # Log calculated values
          echo "Tarball URL: ${URL}"
          echo "Calculated SHA256: ${SHA}"

 # Update the formula using Homebrew
        # brew bump-formula-pr screenpipe \
        #   --url="${URL}" \
        #   --sha256="${SHA}" \
        #   --message="Automated update to version ${VERSION}" \
        #   --no-browse \
        #   --no-audit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants