Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#8551): removes python from cht-deploy and some bug fixes #9074
feat(#8551): removes python from cht-deploy and some bug fixes #9074
Changes from all commits
b6d3d5d
0a4f83c
f9f7d39
744a4e8
a34ace5
80af317
d573940
33f1a3f
df9145b
6588b4c
7481209
2463fdb
e9149ce
b80b010
0742a51
573027e
ef0aa2d
631dca5
d453b7c
1f13203
fdcd892
6dc5c98
0504550
ae75624
3881f89
82cc47b
13322d8
8047f60
e800666
6ccd551
9715f7c
ace7819
5914164
1c61aa8
ebb4e08
74e3667
f1935b7
011fe8d
d27b3bf
b23228d
0a41d43
40b505a
18c4b18
4c18f17
363f50c
ae773a3
ddbf188
eb3ec1c
f6edf08
81c64a2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before the script does anything else, I think we need to check for the
node
version. The reason isbash
is very universal, but who knows what version ofnode
folks have. My desktop defaults to12.0.0
which pretty ensures it'll break everything, for example. Per this post, looks like we can easily get the SemVer of node back to old versions.here's my shell session when debugging this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this was fixed and then a regression was caused, but this doesn't work for me, all be it with a different error than when I first ran it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it isn't linted with our rules.
These are our linting rules: https://github.com/medic/cht-core/blob/master/.eslintrc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was skipped. Fixed.
The whole thing is linted by our linting rules with overrides configured here: https://github.com/medic/cht-core/blob/cht-deploy-fixes/scripts/deploy/.eslintrc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is Sonar complaining about here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About using a user supplied value in a shell script. This is not a problem because the user who runs the script is the user who provides this value under his own user/credentials and access levels.