Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#8703): clean up and organize e2e tests folders db, navigation, privacy-policy, purge and pwa #9271

Merged
merged 23 commits into from
Aug 14, 2024

Conversation

tatilepizs
Copy link
Contributor

@tatilepizs tatilepizs commented Jul 19, 2024

Description

Clean up and organize the following e2e tests:

  • /db

    • db-access-for-custom-roles.wdio-spec.js
    • db-sync.wdio-spec.js
    • feedback-docs.wdio-spec.js
    • initial-replication.wdio-spec.js
    • ongoing-replication.wdio-spec.js
  • /navigation

    • bfcache.wdio-spec.js
    • hamburger-menu.wdio-spec.js
    • navigation.wdio-spec.js
  • /privacy-policy

    • privacy-policy.wdio-spec.js
  • /purge

    • purge.wdio-spec.js
  • /pwa

    • manifest.wdio-spec.js
  • page-objects

    • privacy-policy.wdio.page

#8703

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@tatilepizs tatilepizs changed the title chore(#8703): clean up and organize e2e tests folders /db, /navigation, /privacy-policy, /purge, /pwa chore(#8703): clean up and organize e2e tests folders db, navigation, privacy-policy, purge and pwa Jul 19, 2024
@tatilepizs tatilepizs marked this pull request as ready for review July 22, 2024 19:11
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tatilepizs, for this! I have left a couple of suggestions and questions in the code.

tests/e2e/default/purge/purge.wdio-spec.js Outdated Show resolved Hide resolved
tests/e2e/default/purge/purge.wdio-spec.js Outdated Show resolved Hide resolved
tests/e2e/default/purge/purge.wdio-spec.js Outdated Show resolved Hide resolved
tests/e2e/default/purge/purge.wdio-spec.js Outdated Show resolved Hide resolved
tests/e2e/default/purge/purge.wdio-spec.js Show resolved Hide resolved
tests/e2e/default/db/db-sync.wdio-spec.js Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 197, we define the createMetaDoc function, which I have seen in several places with similar definitions, such as `tests/utils/cht-db.js. ' I don't know if this is in the scope of this cleanup and organized work, but defining a function and reusing it would be beneficial.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you would like to make this part of the scope, and I will help you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is a great idea, but if is ok with you I would rather to have a separate PR due to it will affect other files that are out of the folders defined i n the PR. We can discuss more about how we can do it.

Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tatilepizs tatilepizs merged commit 1b40d15 into master Aug 14, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants