-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(#8703): clean up and organize e2e tests folders db, navigation, privacy-policy, purge and pwa #9271
Conversation
…clean-up-and-organize-folders
…clean-up-and-organize-folders
…clean-up-and-organize-folders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tatilepizs, for this! I have left a couple of suggestions and questions in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 197, we define the createMetaDoc
function, which I have seen in several places with similar definitions, such as `tests/utils/cht-db.js. ' I don't know if this is in the scope of this cleanup and organized work, but defining a function and reusing it would be beneficial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you would like to make this part of the scope, and I will help you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is a great idea, but if is ok with you I would rather to have a separate PR due to it will affect other files that are out of the folders defined i n the PR. We can discuss more about how we can do it.
…clean-up-and-organize-folders
…clean-up-and-organize-folders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…clean-up-and-organize-folders
…clean-up-and-organize-folders
Description
Clean up and organize the following e2e tests:
/db
/navigation
/privacy-policy
/purge
/pwa
page-objects
#8703
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.