Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Order service's update method #9902

Open
wants to merge 1 commit into
base: v1.x
Choose a base branch
from
Open

Update Order service's update method #9902

wants to merge 1 commit into from

Conversation

lukebui
Copy link
Contributor

@lukebui lukebui commented Nov 3, 2024

Since no_notification is an optional boolean, should check if it's empty or not.

@lukebui
Update Order service's update method
1543f65 
Since `no_notification` is an optional boolean, should check if it's empty or not.
@lukebui lukebui requested a review from a team as a code owner November 3, 2024 01:32
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2024

⚠️ No Changeset found

Latest commit: 1543f65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 3, 2024

@lukebui is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

adrien2p
adrien2p approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebui @adrien2p