Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Allow using enter key to create newline in Textarea #9913

Merged
merged 4 commits into from
Nov 5, 2024
Merged

fix(dashboard): Allow using enter key to create newline in Textarea #9913

merged 4 commits into from
Nov 5, 2024
+45 −8

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Nov 4, 2024 •
edited
Loading

What

  • Adds rule to KeyboundForm to allow using the Enter key to add a newline in Textareas.
  • Adds missing toasts to product edit form.

Resolves CC-654

@kasperkristensen kasperkristensen requested a review from a team as a code owner November 4, 2024 08:59
@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 11:52am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 4, 2024 11:52am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 11:52am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 11:52am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 11:52am
medusa-docs ⬜️ Ignored (Inspect) Nov 4, 2024 11:52am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 11:52am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 250d192

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kasperkristensen kasperkristensen linked an issue Nov 4, 2024 that may be closed by this pull request
Bug: admin dashboard, product description #9895
Closed
@olivermrbl olivermrbl merged commit d19d7a6 into develop Nov 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: admin dashboard, product description
2 participants
@kasperkristensen @olivermrbl