Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use collection handle for urls #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

qwernser
Copy link

urls of products respect the handles, so i guess it would be better to follow that for collections

@vercel
Copy link

vercel bot commented Mar 20, 2023

@qwernser is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

["get_collection", id],
() => fetchCollection(id)
["get_collection_by_handle", handle],
() => fetchCollection(handle)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use fetchCollectionByHandle instead, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants