Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable add to cart when no variant #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

burbma
Copy link

@burbma burbma commented May 21, 2023

The add to cart button doesn't do anything when there is no variant selected which makes sense because you need to pick a size when buying a sweatshirt. However the button looks like it's an active button and looks like it's being clicked. This change makes the UI reflect the underlying reality of the button not doing anything.

Note that I'm brand new to Medusa and e-commerce in general, I won't be offended if I'm told I'm off base. For example, perhaps there are products that don't have variants, what happens then? Given that the seed data has variants this provides for a better first time experience but perhaps isn't fully correct.

The add to cart button doesn't do anything when there is no variant selected which makes sense because you need to pick a size when buying a sweatshirt. However the button looks like it's an active button and looks like it's being clicked. This change makes the UI reflect the underlying reality of the button not doing anything.

Note that I'm brand new to Medusa and e-commerce in general, I won't be offended if I'm told I'm off base. For example, perhaps there are products that don't have variants, what happens then? Given that the seed data has variants this provides for a better first time experience but perhaps isn't fully correct.
@vercel
Copy link

vercel bot commented May 21, 2023

@burbma is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@samkit5495
Copy link

@VariableVic can we get some help here on merging this, thanks

@luluhoc
Copy link
Contributor

luluhoc commented Nov 8, 2023

merge this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants