Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DateTime.getNormalizedDay #133

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add DateTime.getNormalizedDay #133

wants to merge 1 commit into from

Conversation

meduzen
Copy link
Owner

@meduzen meduzen commented Apr 12, 2024 •
edited
Loading

Built upon #132. Set as draft until #132 is merged.

As it’s centered around the idea that a week starts on Monday, check if it needs a setting defining the first day of the week.

Missing:

  • tests
  • documentation
  • changelog
  • while on it, should we do the same for month (getNormalizedMonth())?
  • decide for a setting (or no setting) to set the first day of the week (only for DateTime.getNormalizedDay)

@meduzen meduzen added the enhancement New feature or request label Apr 12, 2024
@meduzen meduzen self-assigned this Apr 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
datetime 601 B (0%)
utc 605 B (0%)
datetimeTz 843 B (0%)
duration 245 B (0%)
tzOffset 286 B (0%)
setTimeSeparator 125 B (0%)
setTzSeparator 116 B (0%)
daysBetween 68 B (0%)
weekNumber 144 B (0%)
DateTime 663 B (+0.61% 🔺)
All modules (import *) 1.22 KB (+1.06% 🔺)

@meduzen meduzen force-pushed the datetime-getnormalizedday branch 4 times, most recently from c9dee7a to 7519848 Compare April 12, 2024 21:21
@meduzen meduzen force-pushed the datetime-getnormalizedday branch from 7519848 to fc86a2c Compare April 12, 2024 21:26
meduzen
meduzen commented Jul 23, 2024
View reviewed changes
src/datetime-class.js
*
* @returns {number}
*/
getNormalisedDay = () => getNormalizeDay(this)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be getNormalizedDay with a z instead of a s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@meduzen meduzen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@meduzen