CV2-4187-Determine-what-percentage-of-an-image-is-text #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o convert text_annotations to json
ahmednasserswe
requested review from
DGaffney,
skyemeedan and
computermacgyver
as code owners
DGaffney
requested changes
Aug 30, 2024
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
* Revert "Merge pull request #444 from meedan/CV2-4187-Determine-what-percentage-of-an-image-is-text" This reverts commit 40b5874, reversing changes made to 10901da. * resolving conflicts while reverting * Revert "Print `texts` instead of `response` in `ImageOcrResource`" This reverts commit 9314332. * Revert "Merge pull request #443 from meedan/CV2-4187-Determine-what-percentage-of-an-image-is-text" This reverts commit 10901da, reversing changes made to b36ad46. * resolving conflicts while reverting 8c76c20 * Revert "change the logging in image_ocr_controller.py to use `json.dumps(response)`" This reverts commit 9052fda. * Revert "Merge pull request #442 from meedan/CV2-4187-Determine-what-percentage-of-an-image-is-text" This reverts commit b36ad46, reversing changes made to 5413a6e.
… of github.com:meedan/alegre into CV2-4187-Determine-what-percentage-of-an-image-is-text
DGaffney
reviewed
Sep 4, 2024
DGaffney
requested changes
Sep 4, 2024
…ception` to `Exception` in `google_client.py`
|
Code Climate has analyzed commit 829536f and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 88.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 79.7%. View more on Code Climate. |
DGaffney
approved these changes
Sep 4, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logging to Image OCR response so we can gather data about the boxes size of texts inside images. This later will help determining when do we need to deal with images only as text depending on which percentage of an image is text.
Reference: CV2-4187 (to provide additional context)