Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 'less' notification viewing logic #86

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Conversation

LangLangBart
Copy link
Collaborator

@LangLangBart LangLangBart commented May 3, 2024

description

  • less scrolls to the bottom of the page using the +G flag for Issues/Pull Requests with at least one comment

  • minimize duplication for gh api calls with a gh_rest_api function

  • style change by using [[ … ]] over [ … ]

  • on 31/May/24 I noticed for the first time ever, that the .updated_at field was null for a notification, applied a fix to it

@LangLangBart LangLangBart merged commit de732ab into main Jul 17, 2024
1 check passed
@LangLangBart LangLangBart deleted the view_in_pager branch July 21, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant