Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto-exit on empty list and improve bindings #95

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LangLangBart
Copy link
Collaborator

@LangLangBart LangLangBart commented Aug 11, 2024

Description

When pressing ⌃ Control + T or ⏎ Enter, the notification is automatically marked as read. When the list is empty, the program exits automatically after a reload.

In the GIF below, the old behavior reloads the list with a message while fzf remains active. The new behavior will exit fzf if the list becomes empty after pressing Ctrl + T.

Pro

  • Fewer hotkey presses
  • Viewing notifications would mimic the behavior of the GitHub web interface by automatically marking notifications as read

Negative

  • Requires fzf 0.45.0, but many package repositories still ship quite outdated fzf versions1
    • Because of that reason is is just a draft

Footnotes

  1. https://repology.org/project/fzf/versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant