Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Improvements #55

Merged
merged 10 commits into from
Nov 25, 2024
Merged

Various Improvements #55

merged 10 commits into from
Nov 25, 2024

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Jul 30, 2024 •
edited
Loading

This PR implements various quality-of-life improvements:

  • Implement Debug on the Sorter.
  • Introduce a custom Result type
  • Bump version to 0.5.0.
  • Make the MergeFunction a trait
    • Move it into it's own module.
    • Rename it to something else (optional)
    • Make it unsized (only a type, not a struct)
    • Implement it on the fn type (optional)

@Kerollmops Kerollmops changed the title Implement Debug on the Sorter Various Improvements Jul 30, 2024
@Kerollmops Kerollmops mentioned this pull request Aug 30, 2024
Merged
@Kerollmops Kerollmops marked this pull request as ready for review November 25, 2024 15:01
dureuill
dureuill approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🌈

@Kerollmops Kerollmops merged commit 323a77e into main Nov 25, 2024
4 checks passed
@Kerollmops Kerollmops deleted the various-improvements branch November 25, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dureuill dureuill dureuill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kerollmops @dureuill