-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show last updated badge for alternate plugin variants #1719
feat: Show last updated badge for alternate plugin variants #1719
Conversation
✅ Deploy Preview for meltano-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
324bdfe
to
17780e1
Compare
Shields.io does not support last commit for a path in a repo badges/shields#7351
We could add the Airbyte badge back once badges/shields#10041 is released (i.e. last commit for connector path in the repo). |
I think @tayloramurphy had some concerns about the limited real-estate in the current plugin pages so I kinda wanna let him comment |
@edgarrmondragon @pnadolny13 can we get the build for this working so I can see a preview? Hard to compare with just a screenshot. |
ce3635c
to
775da07
Compare
…bol(Symbol.iterator))`
Thanks for fixing the build @ReubenFrankel! Things do seem a bit crowded on mobile: https://deploy-preview-1719--meltano-hub.netlify.app/extractors/tap-tiktok |
@edgarrmondragon Ah yeah, that doesn't look amazing... I forgot about mobile. |
I don't love this. The badging was an attempt to indicate overall quality - but I get why you'd just want to see the latest quick ASAP. I like the proposal of a hover or tap to view some of the data - maybe based on the badge? @pnadolny13 what do you think? |
@ReubenFrankel @tayloramurphy @edgarrmondragon I agree that seeing all of the variant metadata next to each other helps a lot when comparing but were running out of space. The idea of a hover sounds nice. If we had a |
I'll have a look into a tooltip implementation when I find some more time to work on this. 🙂 |
Current state:
Wasn't quite sure how to interpret this, but sounds like it would benefit from a design first - I imagine you would want to compare across more than just last updated date, such as quality and built with the SDK (i.e. existing badges)? |
7eb4094
to
400439f
Compare
I deployed a preview to https://deploy-preview-1779--meltano-hub.netlify.app/extractors/tap-purecloud but the hovers don't seem to work? @pnadolny13 any idea? |
@tayloramurphy I think that deploy was targeting e78acb7, which I accidentally pushed to this branch the other day (hence previous force-push back). |
the tooltip badges look a lot better 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it 👍
@ReubenFrankel this is awesome! Thanks for contributing this. |
Closes #1293
Happy to add "Last updated" back, but thought it looked cleaner without - or we can do something on hover as suggested in #1293.