Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show last updated badge for alternate plugin variants #1719

Merged

Conversation

ReubenFrankel
Copy link
Contributor

@ReubenFrankel ReubenFrankel commented Mar 22, 2024

Closes #1293

image

Happy to add "Last updated" back, but thought it looked cleaner without - or we can do something on hover as suggested in #1293.

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit d6f0f3a
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/667a7cfe151d360008b91bff
😎 Deploy Preview https://deploy-preview-1719--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ReubenFrankel ReubenFrankel force-pushed the feature/alt-variant-last-updated branch from 324bdfe to 17780e1 Compare March 22, 2024 01:11
@ReubenFrankel ReubenFrankel marked this pull request as draft March 22, 2024 09:11
@ReubenFrankel ReubenFrankel marked this pull request as ready for review March 22, 2024 15:47
@ReubenFrankel
Copy link
Contributor Author

We could add the Airbyte badge back once badges/shields#10041 is released (i.e. last commit for connector path in the repo).

@edgarrmondragon
Copy link
Collaborator

I think @tayloramurphy had some concerns about the limited real-estate in the current plugin pages so I kinda wanna let him comment

@tayloramurphy
Copy link
Collaborator

@edgarrmondragon @pnadolny13 can we get the build for this working so I can see a preview? Hard to compare with just a screenshot.

@edgarrmondragon edgarrmondragon force-pushed the feature/alt-variant-last-updated branch from ce3635c to 775da07 Compare April 4, 2024 03:36
@edgarrmondragon
Copy link
Collaborator

Thanks for fixing the build @ReubenFrankel!

Things do seem a bit crowded on mobile:

Screenshot_2024-04-04-08-13-08-969_com.duckduckgo.mobile.android-edit.jpg

cc @tayloramurphy

https://deploy-preview-1719--meltano-hub.netlify.app/extractors/tap-tiktok

@ReubenFrankel
Copy link
Contributor Author

@edgarrmondragon Ah yeah, that doesn't look amazing... I forgot about mobile.

@tayloramurphy
Copy link
Collaborator

I don't love this. The badging was an attempt to indicate overall quality - but I get why you'd just want to see the latest quick ASAP.

I like the proposal of a hover or tap to view some of the data - maybe based on the badge? @pnadolny13 what do you think?

@pnadolny13
Copy link
Contributor

pnadolny13 commented Apr 17, 2024

I like the proposal of a hover or tap to view some of the data - maybe based on the badge?

@ReubenFrankel @tayloramurphy @edgarrmondragon I agree that seeing all of the variant metadata next to each other helps a lot when comparing but were running out of space. The idea of a hover sounds nice. If we had a Compare variants tool tip that would be ideal. Like put all the variants next to each other in a tabular view to compare across the board that pops up when you click. Idk how challenging these types of things are though.

@ReubenFrankel
Copy link
Contributor Author

I'll have a look into a tooltip implementation when I find some more time to work on this. 🙂

@ReubenFrankel
Copy link
Contributor Author

Current state:

image

If we had a Compare variants tool tip that would be ideal. Like put all the variants next to each other in a tabular view to compare across the board that pops up when you click.

Wasn't quite sure how to interpret this, but sounds like it would benefit from a design first - I imagine you would want to compare across more than just last updated date, such as quality and built with the SDK (i.e. existing badges)?

@tayloramurphy
Copy link
Collaborator

I deployed a preview to https://deploy-preview-1779--meltano-hub.netlify.app/extractors/tap-purecloud but the hovers don't seem to work? @pnadolny13 any idea?

@ReubenFrankel
Copy link
Contributor Author

@tayloramurphy I think that deploy was targeting e78acb7, which I accidentally pushed to this branch the other day (hence previous force-push back).

https://github.com/meltano/hub/actions/runs/9428997282

@edgarrmondragon
Copy link
Collaborator

the tooltip badges look a lot better 🙌

Copy link
Collaborator

@tayloramurphy tayloramurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 👍

@edgarrmondragon edgarrmondragon merged commit 44c7a8c into meltano:main Jun 25, 2024
10 checks passed
@ReubenFrankel ReubenFrankel deleted the feature/alt-variant-last-updated branch June 25, 2024 14:59
@pnadolny13
Copy link
Contributor

@ReubenFrankel this is awesome! Thanks for contributing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Display last commit date in variants list
4 participants