-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow boto3 to use its native credential finding functionality #1536
base: main
Are you sure you want to change the base?
Conversation
Hey @mikejgray can you please resolve the conflicts so that we can test the PR? |
Hi @Dev-Khant , the CI failures don't appear related to the changes in this PR. How would you like me to handle them? |
Hey @mikejgray Those failing CI tests are from a separate issue, it's because poetry is not up to date with libraries mentioned. Could you please add a test script for this and ensure that the approach works for all the different ways the user might pass the credentials? |
I took a look at the proposed changes and there isn't anything in there to test besides what boto3 already provides in their test suite. The way I'm setting up the client is the same way they suggest in the documentation, which also explains the order of credential precedence: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html#configuring-credentials It would also be difficult to test this without having different kinds of credentials, which would need to become a permanent part of your repo secrets and validated in your pipelines to be secure. If you'd like to provide an OIDC AWS role for this repository and an IAM User, with the secrets stored in the repository secrets, I can write an action workflow to do this. It doesn't seem necessary, however, given that boto3 tests this functionality upstream. |
Description
Removes hardcoded AWS credential and region information, allowing boto3 to run through its order of credential precedence. This allows for more secure configurations of AWS credentials to be used, making wider adoption possible.
Fixes #1525
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tried running tests locally but every one of them failed. There was also a missing test dependency I had to add (sqlalchemy) before I could even attempt to run them. I'm hoping there is something in CI that was missing locally, but I'm happy to run tests locally and add some in if I can get some guidance on how to get them to run.
Checklist:
Maintainer Checklist