Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit in get_all and search for Graph #1920

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

Dev-Khant
Copy link
Member

@Dev-Khant Dev-Khant commented Sep 27, 2024

Description

Add the limit param in get_all and search while using graph.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@Dev-Khant Dev-Khant merged commit 68c7355 into main Sep 27, 2024
5 checks passed
@Divyanshu9822
Copy link
Contributor

@Dev-Khant i was trying to utilise graph memory and encountered error related to param limit. It say that line 54 in graph_memory.py has missing argument limit and i verified it also, after removing limit from everywhere i was able to use the memory

@Dev-Khant Dev-Khant deleted the user/dev/add-limit-param branch September 30, 2024 17:51
@Dev-Khant
Copy link
Member Author

Hey @Divyanshu9822, Thanks for mentioning this issue. I have fixed issue in #1930 please check now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants