Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] Error handling for update method in OSS & platform code. #1939

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

parshvadaftari
Copy link
Contributor

Description

This PR introduces improved error handling in the update method. If a memory_id does not exist, it now handles the situation gracefully without displaying an error. This change enhances the user experience by preventing unnecessary error messages.

Fixes #xxxx

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx
  • Made sure Checks passed

@Dev-Khant
Copy link
Member

Thank you @parshvadaftari for the contribution.

@Dev-Khant Dev-Khant merged commit c689f94 into mem0ai:main Oct 8, 2024
5 checks passed
This was referenced Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants