Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove crc calculation #41

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Remove crc calculation #41

merged 4 commits into from
Nov 27, 2023

Conversation

Noarkhh
Copy link
Contributor

@Noarkhh Noarkhh commented Nov 23, 2023

  • Remove CRC calculation in verification, since a slightly corrupted packet can still be reconstructed by the decoder

@Noarkhh Noarkhh marked this pull request as ready for review November 27, 2023 15:07
@Noarkhh Noarkhh requested a review from mat-hek November 27, 2023 15:08
@mat-hek mat-hek merged commit 9113577 into master Nov 27, 2023
3 checks passed
@mat-hek mat-hek deleted the remove-crc-calculation branch November 27, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

@bblaszkow06 bblaszkow06 Awaiting requested review from bblaszkow06

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noarkhh @mat-hek