Add usage example. Deprecate AAC.Filler #45

varsill · 2024-09-19T10:13:32Z

adds example of using parser and filler
makes the filler use pts field of the buffer instead of custom current_timestamp field in the metadata
deprecated AAC.Filler

lib/membrane/aac/filler.ex

Co-authored-by: Mateusz Front <mfront3@gmail.com>

varsill added 8 commits September 19, 2024 11:49

Add simple usage example

8111fa9

Adjust tests to timestamps in pts field of the buffer

490fee4

Use pts field in output buffer

cdf7804

Use dts if pts are missing

e9440cc

Update credo

04190dd

Add silence filling example

2350c1a

Remove parse_and_fill example. Add parsing and MP4 payloading example

481e5dd

Deprecate Filler

3f700da

varsill changed the title ~~Add usage example~~ Add usage example. Deprecate AudioFiller Sep 19, 2024

varsill changed the title ~~Add usage example. Deprecate AudioFiller~~ Add usage example. Deprecate AAC.Filler Sep 19, 2024

varsill added 4 commits September 19, 2024 16:57

Remove unused code from the example

fe08e78

Bump to v0.18.2

553d907

Fix credo warning

e906435

Remove deprecation of the silent_frame/1 function

1fca7ca

varsill requested a review from mat-hek September 19, 2024 15:02

mat-hek approved these changes Sep 19, 2024

View reviewed changes

lib/membrane/aac/filler.ex Outdated Show resolved Hide resolved

varsill and others added 2 commits September 20, 2024 16:41

Update lib/membrane/aac/filler.ex

beeaba8

Co-authored-by: Mateusz Front <mfront3@gmail.com>

Perform formatting

8c28ed7

varsill merged commit 5c575ab into master Sep 20, 2024
3 checks passed

varsill deleted the add_usage_example branch September 20, 2024 15:39

varsill mentioned this pull request Sep 20, 2024

[AAC plugin] Add usage example membraneframework/membrane_core#727

Closed

Provide feedback