Add an option to pass AudioSpecificConfig() #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
force-pushed
the
config-option
branch
from
8088528
to
edbfaf6
Compare
varsill
requested changes
Sep 25, 2024
lib/membrane/aac/parser.ex
Outdated
| @@ -8,6 +8,8 @@ defmodule Membrane.AAC.Parser do | |||
| If PTS is absent, it calculates and puts one based on the sample rate. | |||
| """ | |||
| use Membrane.Filter | |||
| require Membrane.Logger | |||
| alias Hex.State | |||
There was a problem hiding this comment.
whoops, lsp added that
lib/membrane/aac/parser.ex
Outdated
| default: nil, | ||
| description: """ | ||
| Decoder configuration data AudioSpecificConfig() - if received | ||
| from a side channel it should be provided via this option. |
There was a problem hiding this comment.
Suggested change
| from a side channel it should be provided via this option. | |
| via side channel it should be provided via this option. |
lib/membrane/aac/parser.ex
Outdated
| spec: binary() | nil, | ||
| default: nil, | ||
| description: """ | ||
| Decoder configuration data AudioSpecificConfig() - if received |
There was a problem hiding this comment.
You can also refer to ISO/IEC 14496-3 here
lib/membrane/aac/parser.ex
Outdated
| be additionally provided and will be encoded in the `esds`. If not known they should be set to 0. | ||
| Determines which config spec will be generated and included in output stream format as `config`: | ||
| - `esds` - the field will be an `esds` MP4 atom. `avg_bit_rate` and `max_bit_rate` can be | ||
| additionally provided and will be included in the `esds`. If not known they should be set to 0. |
There was a problem hiding this comment.
Suggested change
| additionally provided and will be included in the `esds`. If not known they should be set to 0. | |
| additionally provided and will be included in the `esds`. If not provided, they will be set to 0. |
lib/membrane/aac/parser.ex
Outdated
Comment on lines
123
to
126
| non_nil_config -> | ||
| Membrane.Logger.warning( | ||
| "AAC config provided both with stream_format and options, ignoring the latter" | ||
| ) |
There was a problem hiding this comment.
what about a case where stream_format.config is not nil and state.audio_specific_config is nil? We shouldn't print that message then.
There was a problem hiding this comment.
I would also consider rewriting it with some cond clause as I think it could be more descriptive if you wrote something like: config == nil and state.audio_specific_config == nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.