Allow callers to provide their own Agora SDK and add noop compilation for non-linux machines #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
requested changes
Apr 2, 2024
c_src/membrane_agora_plugin/noop.cpp
Outdated
| {"hello", 0, hello} | ||
| }; | ||
|
|
||
| ERL_NIF_INIT(niftest,nif_funcs,NULL,NULL,NULL,NULL) |
There was a problem hiding this comment.
As discussed in the private conversation - the first argument of the ERL_NIF_INIT macro defines the Erlang module name that is capable of loading that NIF. We need to define separate NIFs for Elixir.Membrane.Agora.Sink.Native.Nif and for Elixir.Membrane.Agora.Source.Native.Nif
README.md
Outdated
There was a problem hiding this comment.
It would be good to bump the version from 0.2.1 into 0.2.2 in the README.md as well
…nifex.Loader conditional. Bump version in README
|
I have implemented the requested changes in this PR: nickdichev-firework#1 |
…_provider_fixes Conditional Agora SDK compilation fixes
mat-hek
approved these changes
Apr 3, 2024
varsill
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve two problems: