precommit: terraform fmt makes changes on disk
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Issues Addressed Most of our pre-commit checks just make the changes that are rote, obvious changes. Not `terraform fmt`! And there's no reason for it, it's just someone decided to do it that way and the maintainers won't switch it back. Comment thread: gruntwork-io#48 ### Summary of Changes I patched precommit to use the expected behavior. I included a shell file to add the patch so it's easy to stay up-to-date with upstream. ### Test Plan - Tested that precommit now automatically updates terraform files when using this branch for precommit.
|
So just to recap: |
|
@vlindhol that's exactly correct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Addressed
Most of our pre-commit checks just make the changes that are rote, obvious
changes. Not
terraform fmt! Instead, it just reports the error and exits,meaning you have to fix the issue manually. And there's no reason for it, it's
just someone decided to do it that way and the maintainers won't switch it
back. Comment thread: gruntwork-io#48
Summary of Changes
I patched precommit to use the expected behavior. I included a shell
file to add the patch so it's easy to stay up-to-date with upstream.
Test Plan
using this branch for precommit.