Malt-webview can now process json greater than 512 MB #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 25, 2024 17:46
This allows us to load big json files (i.e. greater than 512 MB) using the big-json package.
+ update the README.md of the project with information related to big files + fixed a typo in the manpages
+ The state of the repository was obtained with the command `npm install --no-package-lock --save big-json`
|
Thanks for fixing this issue, I encountered it a long time ago. I merge you PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After profiling some huge code base I ended up being unable to view the profiling done by Malt due to my file being close to 1 GB.
This PR changes the way the file is read, and uses streams to
It was tested on my 1 GB file and it works fine. Obviously (?) the web interface is a bit less responsive and need to be refreshed for everything to appear cleanly.
I updated the README in accordance.
/!\ Disclaimer : this is my first time writing NodeJS so feel free to improve it.
Feel free to ask if I need to change anything to allow for this PR.