-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WC-2473]: add expose selection to Combobox #1103
Open
gjulivan
wants to merge
22
commits into
main
Choose a base branch
from
combobox_expose_selection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eac6f42
to
e68256b
Compare
e68256b
to
7129ce4
Compare
e2c7ce0
to
efe2e21
Compare
61efa1c
to
bf3db05
Compare
3534419
to
9f1c880
Compare
bf3db05
to
1ab5ba9
Compare
1e55447
to
72d93ed
Compare
Base automatically changed from
feat/WC-2054-combobox-datasource-filtering
to
main
June 19, 2024 13:43
4bca8e7
to
ca73eb5
Compare
iobuhov
previously approved these changes
Jun 24, 2024
ca73eb5
to
9cd51ef
Compare
e72a0ec
to
19cf6ef
Compare
r0b1n
reviewed
Jul 12, 2024
packages/pluggableWidgets/combobox-web/src/helpers/Database/BaseDatabaseSingleSelector.ts
Outdated
Show resolved
Hide resolved
604a31f
to
b897936
Compare
iobuhov
previously approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bf67f64
to
1e64638
Compare
1e64638
to
909a19a
Compare
samuelreichert
previously approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description