Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WC-2473]: add expose selection to Combobox #1103

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

gjulivan
Copy link
Contributor

@gjulivan gjulivan commented Jun 5, 2024

Pull request type


Description

@gjulivan gjulivan changed the title feat(cb): add expose selection [DRAFT] cb: add expose selection Jun 5, 2024
@gjulivan gjulivan changed the title [DRAFT] cb: add expose selection [DRAFT][WC-2473] cb: add expose selection Jun 5, 2024
@samuelreichert samuelreichert changed the base branch from main to feat/WC-2455-combobox-spinner-skeleton June 10, 2024 07:47
@samuelreichert samuelreichert changed the base branch from feat/WC-2455-combobox-spinner-skeleton to feat/WC-2054-combobox-datasource-filtering June 10, 2024 07:47
@samuelreichert samuelreichert force-pushed the feat/WC-2054-combobox-datasource-filtering branch from e2c7ce0 to efe2e21 Compare June 10, 2024 08:53
@samuelreichert samuelreichert force-pushed the combobox_expose_selection branch 2 times, most recently from 61efa1c to bf3db05 Compare June 11, 2024 08:51
@samuelreichert samuelreichert marked this pull request as ready for review June 11, 2024 08:52
@samuelreichert samuelreichert requested a review from a team as a code owner June 11, 2024 08:52
@samuelreichert samuelreichert force-pushed the feat/WC-2054-combobox-datasource-filtering branch 4 times, most recently from 3534419 to 9f1c880 Compare June 13, 2024 09:37
@samuelreichert samuelreichert changed the title [DRAFT][WC-2473] cb: add expose selection [WC-2473]: add expose selection to Combobox Jun 13, 2024
@samuelreichert samuelreichert force-pushed the feat/WC-2054-combobox-datasource-filtering branch from 1e55447 to 72d93ed Compare June 14, 2024 08:12
Base automatically changed from feat/WC-2054-combobox-datasource-filtering to main June 19, 2024 13:43
@samuelreichert samuelreichert force-pushed the combobox_expose_selection branch 3 times, most recently from 4bca8e7 to ca73eb5 Compare June 21, 2024 10:02
iobuhov
iobuhov previously approved these changes Jun 24, 2024
@gjulivan gjulivan force-pushed the combobox_expose_selection branch 2 times, most recently from 604a31f to b897936 Compare July 19, 2024 08:08
iobuhov
iobuhov previously approved these changes Jul 22, 2024
Copy link
Collaborator

@iobuhov iobuhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samuelreichert
samuelreichert previously approved these changes Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants