Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native USDC to Baklava #120

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: add native USDC to Baklava #120

merged 1 commit into from
Mar 7, 2024

Conversation

nvtaveras
Copy link
Contributor

@nvtaveras nvtaveras commented Mar 6, 2024

Description

This adds the native USDC pools to Baklava after we recently executed MU06. Baklava uses a mock 6 decimals token but Alfajores will use the actual USDC token deployed by Circle once we execute the proposal there prior to mainnet.

Other changes

Some other small changes to rename bridged tokens to axlXXX

Tested

Ran it locally and did swaps on all directions

Related issues

#119

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • The PR title follows the conventions
  • I have run the regression tests

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
mento-web ✅ Ready (Inspect) Visit Preview Mar 6, 2024 9:05pm

denviljclarke

This comment was marked as duplicate.

denviljclarke
denviljclarke approved these changes Mar 6, 2024
Copy link
Member

@bayological bayological left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to swap into USDC but swapping out does not work. Looks like a decimal issue.
image

@nvtaveras
Copy link
Contributor Author

@bayological Are you doing max in that trade? If so, it's an existing issue not introduced by this PR. You should be able to trade an amount that's near the max

@bayological
Copy link
Member

bayological commented Mar 6, 2024

@bayological Are you doing max in that trade? If so, it's an existing issue not introduced by this PR. You should be able to trade an amount that's near the max

I was doing the max and confirmed this is an existing issue. This is not a great experience for the user, so will bump this so we can fix it soon.

@nvtaveras nvtaveras merged commit 81b142c into main Mar 7, 2024
7 checks passed
@nvtaveras nvtaveras deleted the feat/nativeUSDC branch March 7, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants