Skip to content

chore: extracted prettier form solhint into first class toolchain member #13

chore: extracted prettier form solhint into first class toolchain member

chore: extracted prettier form solhint into first class toolchain member #13

Triggered via push April 22, 2024 09:53
Status Failure
Total duration 30s
Artifacts

ci.yml

on: push
Lint & Test
21s
Lint & Test
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 11 warnings
Lint & Test: src/Oracles.sol#L15
GC: For [ OracleBufferInfo ] struct, packing seems inefficient. Try rearranging to achieve 32bytes slots
Lint & Test: src/Oracles.sol#L29
Main key parameter in mapping rateFeeds is not named
Lint & Test: src/Oracles.sol#L29
Value parameter in mapping rateFeeds is not named
Lint & Test: src/Oracles.sol#L29
'rateFeeds' should start with _
Lint & Test: src/OraclesV2.sol#L21
GC: For [ OracleBufferInfo ] struct, packing seems inefficient. Try rearranging to achieve 32bytes slots
Lint & Test: test/Oracles.t.sol#L9
'oracles' should start with _
Lint & Test: test/Oracles.t.sol#L11
'aRateFeed' should start with _
Lint & Test: test/Oracles.t.sol#L144
Named parameters missing. MIN unnamed argumenst is 4
Lint & Test: test/Oracles.t.sol#L169
'anotherRateFeed' should start with _
Lint & Test: test/Oracles.t.sol#L170
'aDataProvider' should start with _
Lint & Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Lint & Test: src/Oracles.sol#L29
Explicitly mark visibility of state
Lint & Test: src/Oracles.sol#L30
Code contains empty blocks
Lint & Test: src/Oracles.sol#L32
Code contains empty blocks
Lint & Test: src/Oracles.sol#L34
Code contains empty blocks
Lint & Test: src/Oracles.sol#L39
Code contains empty blocks
Lint & Test: src/Oracles.sol#L41
Code contains empty blocks
Lint & Test: src/Oracles.sol#L46
Code contains empty blocks
Lint & Test: src/Oracles.sol#L51
Code contains empty blocks
Lint & Test: src/Oracles.sol#L61
Code contains empty blocks
Lint & Test: src/Oracles.sol#L63
Code contains empty blocks