-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Car Remotes #2764
base: master
Are you sure you want to change the base?
Conversation
Thanks! Simple decoders without value processing or checksums are best implemented as flex decoder confs, for examples see https://github.com/merbanan/rtl_433/tree/master/conf For PWM Short and long need to be different, is your code that a typo? E.g.
You can just add a documented conf to this PR. |
I have a few devices on the 433Mhz frequency already and just using the flex decoder was causing false positives. I added a few sanity checks here that removed the false positives: rtl_433/src/devices/audiovox_car_remote.c Lines 69 to 71 in d743eb6
|
ae98d2c
to
301a892
Compare
30746e9
to
6077f7d
Compare
I've finished decoding / reverse engineering all of the keyfobs I have as mentioned in #2754. Let me know if there's any formatting or changes needed. I also have this PR open: merbanan/rtl_433_tests#462 that documents and adds some sample data for these devices. |
@merbanan, @zuckschwerdt It's been almost a year since I've opened this PR. Just want to check in to see if needs any changes before merging. |
Just yesterday someone asked about HCS362 so this is interesting to some people. I'll try to review but this is really much code and not as plain as other decoders we have. Can you rebase and make sure that all files end with a linefeed? At a quick glance the codes in the button_map's look too random. Are you sure that's not the codes for one specific sender? |
b83e70f
to
a44ebef
Compare
@zuckschwerdt I've rebased against the current master branch and fixed the formatting.
Yeah I'm sure they are generic for each model. I have multiple examples of each device that I used to test with. Some of the remotes have multiple buttons that result in relatively complex bit-wise combinations. such as holding two or more down at the same time, etc. |
Add support for multiple car remotes / keyfobs.
See merbanan/rtl_433_tests#462 for decode samples and documentation.
Manufacturer / Model:
Resolves #2754