Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

garm-server urls needs to be configured via API #150

Closed
bavarianbidi opened this issue Jul 30, 2024 · 0 comments · Fixed by #158
Closed

garm-server urls needs to be configured via API #150

bavarianbidi opened this issue Jul 30, 2024 · 0 comments · Fixed by #158

Comments

@bavarianbidi
Copy link
Member

What is the feature you would like to have?

With the upcoming garm version it's mandatory, that values for callback_url, metadata_url and webhooks_url are set during the initialization process.
ATM, these values are set in the garm-server configuration itself.

As initial step i propose to add these required values into the GarmServer struct:
https://github.com/mercedes-benz/garm-operator/blob/82e82aa8c3efb8dc147de91c7c9451120970f349/pkg/config/config.go#L20C1-L26C2

Afterwards we can abstract this configuration into a dedicated GarmServerCR

Anything else you would like to add?

Already implemented in garm with cloudbase/garm#256.

IIRC it's the only reason why the operator fails when it came to initializing a new garm-instance with version from main.
If this is implemented, all existing operator CRs should work again - but requires some manual interaction once #127 is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant