feat: garm v0.1.5 #158
Merged
feat: garm v0.1.5 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bavarianbidi
reviewed
Sep 9, 2024
bavarianbidi
requested changes
Sep 10, 2024
rafalgalaw
force-pushed
the
feat/garm-v0.1.5
branch
from
88fcd0d to
4231a28
Compare
this adds the conversion generator from https://github.com/kubernetes/code-generator to generate conversion code Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
code got generated by make conversion Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
bavarianbidi
force-pushed
the
feat/garm-v0.1.5
branch
from
69cc4f7 to
d3c3dc4
Compare
Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
bavarianbidi
force-pushed
the
feat/garm-v0.1.5
branch
from
6738e00 to
00bc110
Compare
api/v1beta1/githubendpoint_types.go
Outdated
| APIBaseURL string `json:"apiBaseUrl,omitempty"` | ||
| UploadBaseURL string `json:"uploadBaseUrl,omitempty"` | ||
| BaseURL string `json:"baseUrl,omitempty"` | ||
| CACertBundle []byte `json:"caCertBundle,omitempty"` // TODO: This should be a secret reference |
There was a problem hiding this comment.
@rafalgalaw have you already thought about that?
It's optional (from a garm POV) and only needed, if the garm server doesn't trust the CA.
At least in our case we do not need it. But for others it might be relevant ...
I would prefer a secret ref as well
There was a problem hiding this comment.
as discussed, let's move this towards a secret ref and raise a new PR for this.
In this PR we will remove this field
as we do not do pool adoption anymore we can get rid of the test case as well
bavarianbidi
force-pushed
the
feat/garm-v0.1.5
branch
from
34e9203 to
99827da
Compare
bavarianbidi
force-pushed
the
feat/garm-v0.1.5
branch
2 times, most recently
from
5b6f1b7 to
ec09567
Compare
Signed-off-by: Mario Constanti <mario.constanti@mercedes-benz.com>
bavarianbidi
force-pushed
the
feat/garm-v0.1.5
branch
from
ec09567 to
c153b89
Compare
bavarianbidi
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement the new set of changes and api changes garm requires for its version v0.1.5. This includes:
Fixes #150, fixes #143, fixes #127, fixes #139
open ToDos:
1. list all pools for the given org
1. compare pool spec with given pool spec
1. always match first entry and reflect id back
1. if more matches, log a warning