HG proc/core: fix couple of type changes that could have broken ABI

HG proc: fix handle field added that would have broken ABI
mercury-hpc · Aug 1, 2024 · 949b81a · 949b81a
1 parent 4962c6a
commit 949b81a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/mercury_core.h b/src/mercury_core.h
@@ -1083,7 +1083,7 @@ struct hg_core_addr {
 #ifdef NA_HAS_SM
  na_addr_t *na_sm_addr; /* NA SM address */
 #endif
- bool is_self; /* Self address */
+ uint8_t is_self; /* Self address */
 };
 
 /* HG core RPC registration info */
@@ -1092,7 +1092,7 @@ struct hg_core_rpc_info {
  void *data; /* User data */
  void (*free_callback)(void *); /* User data free callback */
  hg_id_t id; /* RPC ID */
- bool no_response;  /* RPC response not expected */
+ uint8_t no_response; /* RPC response not expected */
 };
 
 /* HG core handle */
@@ -1255,7 +1255,7 @@ HG_Core_addr_get_na_sm(hg_core_addr_t addr)
 static HG_INLINE bool
 HG_Core_addr_is_self(hg_core_addr_t addr)
 {
- return addr->is_self;
+ return (bool) addr->is_self;
 }
 
 /*---------------------------------------------------------------------------*/

diff --git a/src/mercury_proc.h b/src/mercury_proc.h
@@ -597,7 +597,7 @@ struct hg_proc_buf {
  void *buf_ptr; /* Pointer to current position */
  hg_size_t size; /* Total buffer size */
  hg_size_t size_left; /* Available size for user */
- bool is_mine;
+ uint8_t is_mine;
 #ifdef HG_HAS_XDR
  XDR xdr;
 #endif
@@ -608,7 +608,6 @@ struct hg_proc {
  struct hg_proc_buf proc_buf;
  struct hg_proc_buf extra_buf;
  hg_class_t *hg_class; /* HG class */
- hg_handle_t handle; /* HG handle */
  struct hg_proc_buf *current_buf;
 #ifdef HG_HAS_CHECKSUMS
  struct mchecksum_object *checksum; /* Checksum */
@@ -617,6 +616,7 @@ struct hg_proc {
 #endif
  hg_proc_op_t op;
  uint8_t flags;
+ hg_handle_t handle; /* HG handle */
 };
 
 /*---------------------------------------------------------------------------*/