HG Core: add copy_on_multi_recv and multi_recv_copy_threshold #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostedcmos
reviewed
Jul 16, 2024
src/mercury_core_types.h
Outdated
Comment on lines
118
to
120
| * Default value is: false */ | ||
| bool copy_on_multi_recv; | ||
|
|
There was a problem hiding this comment.
Looks like the intention for this experimental patch was to always copy, but since this is false by default it will not?
There was a problem hiding this comment.
What made you think that? No the intent was to not copy by default. It's not really experimental I just made a patch that I can merge eventually. I also updated one of my cart PRs to set this to true to always copy as an experiment.
There was a problem hiding this comment.
Ah ok, the ticket PR for Saurabh to try only mentioned this PR and not the cart one, so i thought this was supposed to enable it by default. Makes sense now:)
soumagne
force-pushed
the
mrecv_copy
branch
3 times, most recently
from
46dcfd3
to
9479bc0
Compare
Use this new parameter to fallback to memcpy to prevent starvation of multi-recv buffers and potential deadlock situations. Fix auto sm cap disabled with multi-recv
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use these two new parameters to fallback to memcpy to prevent starvation of multi-recv buffers and potential deadlock situations.